Google Git
Sign in
chromium / chromium / src / d9175b2f2c62d964d6b15968e0a71bf1d0bae040
commitd9175b2f2c62d964d6b15968e0a71bf1d0bae040[log] [tgz]
authorChristoph Schwering <schwering@google.com>Fri Dec 06 16:40:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 06 16:40:54 2024
tree76bb818ead7046c22a94b45fca115ec0ccd7e953
parent3568120a41e7b71f19be9ec58fe582cc14b80a6e [diff]
[Autofill] Rename some functions, variables in VotesUploader

This CL renames some variables and functions for more consistency
in VotesUploader:

- `OnSubmissionFieldTypesDetermined()` --> OnFieldTypesDetermined()`
  Reason: the meaning of "submission" is unclear, especially since
  the function is also called with `is_submission = false`.

- `FlushPendingVotes()` --> FlushQueuedVotes()`
  Reason: avoid two concepts for the same thing; originally I had
  thought I'd need the term "pending" for asynchronous tasks.

- `QueuedVote::callback` --> `QueuedVote::upload_vote`
  Reason: more descriptive.

- `interaction_time` --> `initial_interaction_timestamp`
  `submittion_time` --> `submission_timestamp`
  Reason: consistency.

- `source_id` --> `ukm_source_id`
  Reason: consistency.

- `queued_vote_uploads_` --> `queued_votes_`
  Reason: consistency with the type name.

- `form_structure` --> `form`
  Reason: reduce noise; there are no non-FormStructure forms in
  VotesUploader.

Bug: 374086145
Change-Id: I05e4454055509f802cbbccd6cf382e887bad5cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6074473
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1392952}
5 files changed
tree: 76bb818ead7046c22a94b45fca115ec0ccd7e953
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.