Google Git
Sign in
chromium / chromium / src / d9314938deefac832c2632a42a2cf08754c8a57b
commitd9314938deefac832c2632a42a2cf08754c8a57b[log] [tgz]
authorMichelle <michellegc@google.com>Tue May 21 08:40:15 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 21 08:40:15 2024
tree71052064792679cf6621644df189c2c74b9070a0
parentbb28cb05e91036b7d4ddbc09aa282f48d7ef03fd [diff]
Add max_visible_rows to PickerSmallItemGridView.

We're moving small grid items (emojis, symbols and emoticons) out of the
main Picker container and into a separate emoji bar. The emoji bar will
only show one row of items, so add an option to set the max visible rows
of small item grids. (For now, set the max visible rows as 2 since we
haven't actually moved to the new UI yet.)

After we've moved things into the emoji bar, we may not need to support
multiple rows in the small grid. This can probably let us delete some
code / simplify parts of PickerSmallItemGridView, but leave that to
later once we've confirmed that the multiple row layout is not needed.

Bug: b:340692819, b:340692683
Change-Id: I212a1123c7c26cc41411cb787e2db014a09a3a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553651
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Michelle Chen <michellegc@google.com>
Cr-Commit-Position: refs/heads/main@{#1303647}
3 files changed
tree: 71052064792679cf6621644df189c2c74b9070a0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.