Fix variable shadowing in ui/gfx and enable the warning

Attempts to use ui/gfx code in content failed because of
variable/enum shadowing. The main problem is fixed in

This fixes the remaining problems and enables the shadowing
warning to prevent future problems of the same kind. All the
problems are of the trivial kind, with inner blocks reusing
either the name of a variable or the name of an argument,
be it |cluster|, |font|, |i|, |path|, |alpha| or |line|. In one
case the fix was to delete an unused local variable.

Bug: 923078,794619
Change-Id: Iae8bb768c49332cbe610860e06fea9d7aebc7a4b
Commit-Queue: Daniel Bratell <>
Reviewed-by: Alexei Svitkine <>
Reviewed-by: Peter Kasting <>
Cr-Commit-Position: refs/heads/master@{#625635}
9 files changed