commit d961ba07f5343b65b9ce552779682aae50eaab40
author Daniel Bratell <bratell@opera.com> Thu Jan 24 14:37:38 2019
committer Commit Bot <commit-bot@chromium.org> Thu Jan 24 14:37:38 2019
tree 8999123d51f70a19c19f643f655d917034c037e8
parent 203e421c612e5d3e859bde1f575e2aa968a00d7e

Fix variable shadowing in ui/gfx and enable the warning

Attempts to use ui/gfx code in content failed because of
variable/enum shadowing. The main problem is fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/1424799

This fixes the remaining problems and enables the shadowing
warning to prevent future problems of the same kind. All the
problems are of the trivial kind, with inner blocks reusing
either the name of a variable or the name of an argument,
be it |cluster|, |font|, |i|, |path|, |alpha| or |line|. In one
case the fix was to delete an unused local variable.

Bug: 923078,794619
Change-Id: Iae8bb768c49332cbe610860e06fea9d7aebc7a4b
Reviewed-on: https://chromium-review.googlesource.com/c/1421104
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625635}