commit | d96b9a771e253bf31cb4732a0dae6fde9ce318fe | [log] [tgz] |
---|---|---|
author | Ningxin Hu <ningxin.hu@intel.com> | Wed Dec 13 01:31:56 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 13 01:31:56 2023 |
tree | f7c44f6b12b104f7277e1dfb5452a2bf5bd8d6ee | |
parent | ae6d92651bf5cb304fc1d534cff83fd68959c5bb [diff] |
WebNN: Fix DirectML binding table issue for reshaped constant tensor The reshape operator of DirectML backend is implemented by creating a new tensor description for its input node. However, the previous implementation fails to set the `DML_TENSOR_FLAG_OWNED_BY_DML` flag if its input node is a constant tensor. That caused the DirectML binding table error during graph initialization. This CL fixes this issue by setting the tensor flags of the reshape operator's input tensor description to the output tensor description. This ensures the output tensor description has `DML_TENSOR_FLAG_OWNED_BY_DML` flag if the input node is a constant. Because the previous implementation doesn't check DirectML binding table error, that led the error to be reported when the graph was computed. This CL also fixes that by calling `IDMLDevice::GetDeviceRemovedReason()` after binding table invocations that ensures the error being reported immediately. This CL also adds two test cases for `gemm` and `add` operators that take a reshaped constant operand as input. Bug: 1509747,1273291 Change-Id: I7acd1a1087643077044bf3f13ffe04fc938b1147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5109258 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1236720}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.