Google Git
Sign in
chromium / chromium / src / d979040eec7b2adb42872836db75551bc75d436a
commitd979040eec7b2adb42872836db75551bc75d436a[log] [tgz]
authorSammie Quon <sammiequon@chromium.org>Tue Mar 22 02:27:29 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 22 02:27:29 2022
tree497b02ee417c0748bf883f835636e5dfb82e8508
parentb0d9e4ce53069857d7dc098c734fcb1d7ca22458 [diff]
desk_templates: Fix issue with previews no updating after launch.

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/3511048.

The original CL caused to many updates due to `OnWindowVisibilityChanged`
firing for any window visible change in the tree. This CL reduces the
amount of calls by checking a lot more conditions. There was also a crash
that was caused by the original CL that happens because creating the
DeskPreviewView would cause a visibility change. The extra conditions
stops us from reaching this crash, but adds a DCHECK so a future stack
trace gives more accurate information.

Test: manual
Bug: 1301763, 1307864
Change-Id: I0bbbad52e8ba5f26e5dd5e36e84d971d3906ccf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540618
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#983621}
2 files changed
tree: 497b02ee417c0748bf883f835636e5dfb82e8508
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.