Google Git
Sign in
chromium / chromium / src / d98518b5d39e7547d1954c5e168e95f428bea5d5
commitd98518b5d39e7547d1954c5e168e95f428bea5d5[log] [tgz]
authorsyed.wajid <syed.wajid@samsung.com>Fri Nov 22 05:04:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 22 05:04:25 2024
tree33c520924f315ef4984a2d47bca11e995d2cae6c
parent412ee643722e5f6e54fff27542e29a3fea78eaeb [diff]
Reland "Adds check for service callback before enabling DW."

This is a reland of commit 5fa0d925327bae46b6bb9485cff087ca97bb1bda

A crash was observed while accessing the DirectWritingServiceCallback. To address this issue, additional check is added to verify if the service callback constructor exists in isEnabled and if not, disables DW service.

Original change's description:
> Adds check for service callback before enabling DW.
>
> Checks whether the service callback constructor exists in isEnabled
> and if not, disables DW service. This prevents crashing described in
> crbug/1375266.
>
> Bug: 1375266
> Change-Id: Ie2134ccbdd627b38b1b46e8ad4053227f2b765fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960230
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Mahesh Machavolu <mahesh.ma@samsung.com>
> Commit-Queue: Alex Mitra <alexmitra@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1060407}

(cherry picked from commit 5fa0d925327bae46b6bb9485cff087ca97bb1bda)

Bug: 379724628
Change-Id: I6196cc70acd2d25ffed81e4be1e872106cb57cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038593
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Alex Mitra <alexmitra@chromium.org>
Commit-Queue: Mahesh Machavolu <mahesh.ma@samsung.com>
Cr-Commit-Position: refs/heads/main@{#1386623}
2 files changed
tree: 33c520924f315ef4984a2d47bca11e995d2cae6c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.