[side panel] Address clipping issues during entry/exit animation

The current side panel animation relies on layers being clipped by
the BrowserView (the SidePanel width is fixed, the animation
slowly slides it beyond the bounds of the BrowserView).

However the BrowserView paints to the BrowserFrame layer and this
does not always match BrowserView bounds (extended for painting
client-side window shadows for e.g.). This causes the layer children
of the side panel to appear to clip outside the browser's bounds.

This CL adds VisibleBoundsViewClipper which is responsible for
ensuring any immediate layer children of the SidePanel view are
clipped to their visible bounds (within the BrowserView).

This is intended to be a short term fix to address the acute
problem while a more robust means of handling the WebViews content
layer is explored.

Alternatives considered:

  - Make the SidePanel layer-backed and clipped to visible bounds.
    Doesn't work as this introduces a layer subtree and WebView
    content layers are always parented directly to the Widget's layer

  - Refactor SidePanel so children are added to BorderView instead
    and clip only the border. Better but a bigger change and risky
    if a merge is required

Bug: 337056034, 344626785
Change-Id: I656ba668237df88023f42c136b58aeed7e976e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5593235
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1309651}
2 files changed
tree: c48a4f936505fdbf3021811d0ba3405094a202cc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.