Remove busy loop in test StartupMetricsTest.ReportsValues.

Previously, the test invoked RunLoop::RunUntilIdle() in a loop. The
number of invocations of RunLoop::RunUntilIdle() was unbounded. Since
each invocation posts a delayed task (https://source.chromium.org/chromium/chromium/src/+/master:base/run_loop.cc;l=123-124;drc=fbf3c62ca96c66c95807feb8cb4478cabefb8e3c),
this could cause an OOM crash.

With this CL, the test uses RunLoop::Run() instead of
RunLoop::RunUntilIdle(). A callback is registered to exit the loop
when an histogram is recorded. The number of invocations of
RunLoop::Run() is always the same, which will prevent OOM crashes.
Also, this allows the main thread to sleep when no tasks are ready,
which reduces the test's resource consumption.

Fixed: 1152942
Change-Id: I47e5248f69e1131f034004fecae906e8803a3bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561523
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831580}
1 file changed
tree: 229e347f690afbedb895523bde6258e10890e1d1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.