Always match :focus-visible on focused element according to user preference.

(Very belated reland of https://crrev.com/c/1886075)

The :focus-visible pseudo-selector emulates the existing behaviour of
native elements like buttons by only showing a focus ring when focus is
moved using the keyboard.

This change modifies that behaviour to always match :focus-visible on
the focused element, regardless of how focus was moved (effectively
making :focus-visible equivalent to :focus) if the user has enabled the
"Highlight the object with keyboard focus when it changes" setting on
Chrome OS.

This plumbs through the ash::prefs::kAccessibilityFocusHighlightEnabled
preference on Chrome OS to a new web setting on Blink, and checks that
setting when computing whether :focus-visible matches on the focused
element.

Fixed a bug in the test which was causing leak detector to fail.

TBR=dominickng@chromium.org,ellyjones@chromium.org,falken@chromium.org,tkent@chromium.org,dmazzoni@chromium.org

Bug: 817199
Change-Id: If86d4f1c757cba0b5fd3b19ce55c656054fae671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198842
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768659}
12 files changed
tree: b85444ba6024543ef7dccfb557e9513b1181be9a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.