commit | da3c9037fc53f4c735507f0fd0d1196772681ba9 | [log] [tgz] |
---|---|---|
author | Dave Tapuska <dtapuska@chromium.org> | Fri Jul 20 19:09:11 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 20 19:09:11 2018 |
tree | 263b8fbd2444e346ee5bc1cbb6adc13ce2aa91e9 | |
parent | 0106342e67d4eb9ba4ab6eca7af0548077606daa [diff] |
Fix type_conversions in test code. The code was testing C++ to WebIDL type conversions. It should have not been using C++ long values since these are dynamic based on the architecture. Use the C++ type that maps correctly to the WebIDL type. This didn't cause a layout test failure because it was testing a roundtripped value. If the C++ interface returned a value that was out of bounds then it could have gotten truncated because on linux sizeof(long) == 8 but WebIDL long defines it as 4 bytes. BUG=596846 Change-Id: I92020c1cbbec0fff7c77b5fe0129eb91bbd70c7a Reviewed-on: https://chromium-review.googlesource.com/1145138 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#576944}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .