Do not call GetHttpReasonPhrase
https://crrev.com/c/5371447 introduced calling ::net::GetHttpReasonPhrase to map a `response_code` to a string.
However, when no network is present, `response_code` is 0 and ::net::GetHttpReasonPhrase runs into `NOT_REACHED`, which crashes chrome on non-official builds.
Since this mapping seems mostly for convenience, this CL proposed to remove it. Please let me know if you prefer to fix it differently.
Bug: b:333365281
Change-Id: Ife03b30c33bb44d6c18b33302b345647a92c8517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5434994
Reviewed-by: Alberto Juarez <albertojuarez@google.com>
Commit-Queue: Alberto Juarez <albertojuarez@google.com>
Reviewed-by: Steffen Seckler <sseckler@google.com>
Cr-Commit-Position: refs/heads/main@{#1285940}
diff --git a/chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client.cc b/chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client.cc
index 8ba16a77..03df746 100644
--- a/chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client.cc
+++ b/chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client.cc
@@ -651,9 +651,7 @@
std::move(callback).Run(base::unexpected(
Status(error::DATA_LOSS,
base::StrCat(
- {"Response code: ", base::NumberToString(response_code), " ",
- ::net::GetHttpReasonPhrase(
- static_cast<::net::HttpStatusCode>(response_code))}))));
+ {"Response code: ", base::NumberToString(response_code)}))));
return;
}
if (!response.has_value()) {
