Google Git
Sign in
chromium / chromium / src / da51bc036fe8bb22ff9d893460fae753f25ae69c
commitda51bc036fe8bb22ff9d893460fae753f25ae69c[log] [tgz]
authorTao Wu <wutao@chromium.org>Fri Jun 10 22:36:08 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 10 22:36:08 2022
tree3fa9262be918e08038cfed260d331ac649f98b7b
parent17e831cd9f3680eb9390bcf8664ea79be1cf5f61 [diff]
libassistant-v2: Fix timing to set internal options

Some internal options are expected to only set once before assistant
manager starts.
This cl reverts partial changes in crrev.com/c/3248169, to move some
logic back to OnAssistantClientCreated.
In V2, it is ok to call BootupService in OnAssistantClientCreated.

Bug: b:235616347
Test: Modified SettingsController unittests.
Change-Id: I70f94ebfffa344a214c6d7586f1499ee88857f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3700701
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Jason Thai <jasontt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013167}
3 files changed
tree: 3fa9262be918e08038cfed260d331ac649f98b7b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.