commit | da88a8256a9344f8b013056f15e6775aca60f921 | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Mon Nov 13 02:39:24 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 13 02:39:24 2023 |
tree | 59c936b516ff66c819f4315e30faf9fd6733ced7 | |
parent | 039c00e50469ce337ab86840afad67ef4aa12a74 [diff] |
Prerender: Change FindReservedHostById() to HasReservedHost() This is a pure cleanup, and doesn't change functional behavior. For PrerenderHostRegistry::FindReservedHostById(), its name doesn't match actual function behavior. Only one reserved PrerenderHost exists per PrerenderHostRegistry, so the function just accesses the member field, not *find* it somewhere. Also, this function is now used only for checking if some host is reserved, so the function doesn't need to return a pointer to the reserved host. To reflect the actual behavior and usage, this CL changes FindReservedHostById() to HasReservedHost() that just returns a boolean to indicate if the reserved host exists. For PrerenderNewTabHandle::GetPrerenderHostForTesting(), this is no longer used after https://crrev.com/c/5016385, so this CL removes it. Bug: n/a Change-Id: I85b8ffb302a831f482f48dad74a612ede199647a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5019897 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1223442}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.