| commit | daa5976ab765eb4881d5efe366e976df9ac542a7 | [log] [tgz] |
|---|---|---|
| author | Joey Arhar <jarhar@chromium.org> | Tue Jan 28 23:45:03 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 28 23:45:03 2025 |
| tree | 82af90584e16f00e7f51c7919744d09d63b209aa | |
| parent | 81d689954e8782fbd8c0b41728daf95a3df124ce [diff] |
Remove extra nested <select> <selectedcontent> tracking This sort of makes us match the spec more closely: https://github.com/whatwg/html/pull/10633#discussion_r1927732240 When there is a <selectedcontent> inside nested <select>s, we were adding the <selectedcontent> to all <select>'s descendant selectedcontent element lists. This was probably fine but it also wasn't removed properly in HTMLSelectedContentElement::RemovedFrom, so I'm adding an early return to prevent adding the <selectedcontent> to the upper <select>'s list of descendant selectedcontent elements. Change-Id: I1591ce192ec3033f32de319e4cb5431aec19cfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196578 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1412608}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.