[Mac System Hotkeys] Skip undocumented AppleSymbolicHotKeys

When you change the shortcuts for Spaces Left and Spaces Right, macOS
inserts your new shortcuts at slots 79 and 81 in AppleSymbolicHotKeys.
For some reason, it also inserts "shifted" versions of these
shortcuts at slots 80 and 82. It's unclear why these shifted versions
exist because the shortcuts don't seem to do anything. They could be
entries macOS adds for some reason but knows to skip (not expecting
any non-system application to read this file). Treating these
shortcuts as valid creates unexpected behavior. For example, in the
case of "Spaces Left" being mapped to Option Left Arrow, this extra
shortcut causes Chrome to silently ignore Shift-Option Left Arrow,
the shortcut which appends the current text selection by one word to
the left. This cl works around the problem by changing the
SystemHotkeyMap to ignore these two undocumented shortcuts.

This cl also forces an eventual reload of the SystemHotkeyMap after
the user switches away from Chrome and back, to ensure any new
shortcut settings are recognized.

Bug: 874219

Test: out/Default/content_unittests \
    --gtest_filter=SystemHotkeyMapTest.IgnoreUndocumentedShortcutEntries

Change-Id: Ifc17ec48877de8aeae01244794ec5fcf2444fe5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908188
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077678}
7 files changed
tree: 10246e3c6386c9eead27d0f24473ec877b8fcf35
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.