Improve buildflag header guard generation to handle unsupported chars. Buildflag header generator uses directory structure to create header guards. Any characters that cannot be used as a part of guard identifier should be replaced, but prior this change not all invalid characters were replaced. Currently Chromium does not have issues with invalid guards in buildflag headers, but other Chromium-based projects may encounter this issue. It seems reasonable to fix this globally. The more generalized approach covers all possible invalid chars. Bug: 1313910 Change-Id: I543f9d1286defb7c3b94a010800d3e79fb1dcca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3571751 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#990336}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.