commit db2e68f1727ce5b46b39c4fe82cc7967823f8007
author Alexei Svitkine <asvitkine@chromium.org> Fri Oct 13 19:15:56 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 13 19:15:56 2023
tree d79e355b2084ceeb56fcf22d4abcac380939c2d5
parent b53555665d55a75a1e36b2b9a70af271d85d0b00

Pass --disable-field-trial-config to tests that need it.

Affected tests already run without the testing config applied,
so this CL makes it explicit.

Context: Browser tests that use ScopedFeatureList and pass
params presently cause the field trial testing config to be
entirely disabled. (details: crbug.com/1491463#c8)
We plan to fix this, but some existing tests rely on this
(fail with the testing config). This CL annotates those
tests explicitly by making them specify the flag for that.

Once all the CLs updating such tests land (sharded via git
cl split), the following CL to make ScopedFeatureList not
disable the testing config can land:
https://chromium-review.googlesource.com/c/chromium/src/+/4935093

As many tests are affected, it will be up to their owners
to do any necessary follow up if the tests should be made to
pass with the testing config (per the comments this CL adds).

Note: I did a best effort to have the new flag only apply to the
subset of tests that needed it when it was a single or a small
number of tests that were affected, by introducing subclasses
for the affected tests. In other cases, where lots of tests in
the same file fail, the flag is added to the original test class.

Note: The --disable-field-trial-config flag is passed simply
by name intentionally, to avoid additional complexity from
depending on components/variations and includes to reference
the existing constant for it. The name is unlikely to change and
this way, we need less complex code to add this to the tests.

This CL was uploaded by git cl split.

R=xinghuilu@chromium.org

Bug: 1491463
Change-Id: Ifc55418f755f1f25245838fdda2dde9bf8f3b6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935338
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1209586}