mojo: Remove StringTraits::IsValidUTF8.

This should only affect the Mojo.InvalidUTF8String histogram, since
nothing else appears to rely on this. I would expect that histogram
to change (in one direction or another, depending on which of the
following is more common in the wild):

The WTF implementation of this trait was incorrect, for a few reasons:

* WTF::String::FromUTF8 returns a null string if the input was invalid
  UTF-8, but StringTraits<WTF::String>::IsValidUTF8 returns true in this
  case.

* Plenty of valid UTF-8 strings get a 16-bit representation in Blink,
  but StringTraits<WTF::String>::IsValidUTF8 returns false in this case.
  For example, any string with a CJK or Emoji character would be
  erroneously reported as invalid.

* Plenty of valid UTF-8 strings get an 8-bit representation in Blink
  which is valid Latin-1, but not valid UTF-8. For example, strings
  with non-ASCII characters (e.g., accented Latin characters) may be
  erroneously reported as invalid, depending on what character follows.

Instead, this should check that the input from which the string was
constructed was valid UTF-8. This check is the same regardless of what
the destination type is, so it's moved directly into Deserialize.

Bug: 699319
Change-Id: I078830fde108650d570c90e6248bd5255c89ab2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3999828
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1066711}
5 files changed
tree: 5cc7cd9f21aac36270ad45154495658e03473a20
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.