commit | db6fcdd658240ead9e623af11f97a1172f03b07c | [log] [tgz] |
---|---|---|
author | Xiaodan Zhu <zxdan@chromium.org> | Mon Mar 08 21:09:17 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 08 21:09:17 2021 |
tree | 82ae039060681775c30f92b8f0ed9bb65dd70154 | |
parent | 34fee31b80772949018a367f8a21bfa57fee93f5 [diff] |
Fix the behaviors when a desk is snapping back. This CL fixs the wrong behaviors of dragging a desk while another desk is snapping back. The wrong behaviors are due to the old function call logic. For mouse event, new logic is fixed as below: - Add OnMousePressed in DeskPreviewView to call HandlePressEvent in the DesksBarView. - HandlePressEvent calls InitDragDesk to initialize a drag proxy. - InitDragDesk ends current drag and estimate the initial offset for the new drag but don't create the drag proxy widget. - OnMouseDragged in DesksPreviewView calls HandleDragEvent in the DesksBarView. - HandleDragEvent calls StartDragDesk if drag proxy is initialized. If the drag has already started, then call ContinueDragDesk. - OnMouseReleased in DesksPreviewView calls HandleReleaseEvent in DesksBarView. - HandleReleaseEvent calls EndDragDesk if the drag is started. For gesture event, the function call changes as follow: - ET_GESTURE_LONG_PRESS in DesksPreviewView calls HandleLongPressEvent in the DesksBarView to initialize and start a drag. Bug: 1181089 Change-Id: Ibfae484963523cd32971cb66e29416bf9b2ae159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730508 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#860855}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.