commit db781b1c24e42e21ac6ad7aa8e9f087d24169eea
author Kevin McNee <mcnee@chromium.org> Tue Sep 14 18:32:48 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 14 18:32:48 2021
tree 2a8425b0431755177149ae3709987a4d50e9a25d
parent d6f8cf27dfc056588e9a3aa7962fbe63c692c858

Remove WebContents getter from SafeBrowsing UnsafeResources

We've added frame and document ids to UnsafeResource to fix
SafeBrowsing interstitials for prerendering. This made UnsafeResource's
existing WebContents getter redundant, so we now remove it and instead
provide a function to return the associated WebContents based on the
frame/document ids.

Note that the existing WebContents getters are RFH id to WebContents or
FTN id to WebContents lookups. The ids that would be in the bind state
of the callback are now available on UnsafeResource directly. For
example, if the getter was
base::BindRepeating(&WebContents::FromFrameTreeNodeId,
                    my_frame_tree_node_id)
then we have
resource.render_process_id = /* invalid id */
resource.render_frame_id = /* invalid id */
resource.frame_tree_node_id = my_frame_tree_node_id;
and the new function returns the same result. Likewise for
WebContents::FromRenderFrameHost based WebContents getters.

Bug: 1230802
Change-Id: I0a4f8469638d6ee072d905e93c881197db74ea8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3153341
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921331}