commit db97c930d62c782bf6b13125c2ec49abafec9b42
author Tommy Li <tommycli@chromium.org> Wed May 18 00:17:01 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 18 00:17:01 2022
tree b158f1bf0eb9a566774e9e5991bef19899869018
parent 3c9efd53c1dd1213118834b7650a3349dedd5b1e

[Merge 103] [journeys] Make SimilarVisitDeduperClusterFinalizer use url_for_deduping

In a previous patch, we made SimilarVisitDeduperClusterFinalizer use
url_for_display instead of url_for_deduping:
https://chromium-review.googlesource.com/c/chromium/src/+/3646808

That was not the way to go.

Instead, this CL restores the usage of url_for_deduping, as well as
increases the aggression of url_for_deduping to ALSO strip way the URL
query, so that URLs that differ only by the query part may also be
deduped by SimilarVisitDeduperClusterFinalizer, assuming that the page
title differs.

I added more commentary too, to explain that so long as
url_for_deduping is strictly more aggressive than url_for_display, we
should not display any identical rows in the UI.

(cherry picked from commit d60f7bf318fd7b67f6ebd99175b4726cf8cb9838)

Bug: 1325154
Change-Id: I105f9e74e98924deddf3c2481517962cd12a6b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645237
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003896}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652251
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Auto-Submit: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#64}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}