Google Git
Sign in
chromium / chromium / src / dc27724adaedb220067059a64c006694b1d358c7
commitdc27724adaedb220067059a64c006694b1d358c7[log] [tgz]
authorMehrab N <mehrab@chromium.org>Thu Aug 11 12:29:59 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 11 12:29:59 2022
treee4942a651c2f36eec1c93c96d5b76e4e8d10f339
parent74f316a14a0fc7e8bebf386a7e56907a320bada9 [diff]
autocorrect: separate UndoWindow UI codes from logics

Previously, codes for setup/show Undo Window were implemented together
with the "accept/clear" logics of autocorrect making the logics hard to
read. To improve this situation and make the UI code reusable, they are
now moved into separate functions. A similar change is applied for Undo
Window codes in unittests.

Bug: b:161490813
Change-Id: Idda7ccd5bb5cd606d870ad090abf5ae452ffc05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811090
Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Mehrab N <mehrab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1033947}
3 files changed
tree: e4942a651c2f36eec1c93c96d5b76e4e8d10f339
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.