commit | dc3d019389092bb57ab9f22511c3e94445b64a0f | [log] [tgz] |
---|---|---|
author | Louis Romero <lpromero@google.com> | Tue May 07 16:39:56 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 07 16:39:56 2024 |
tree | 65bf8e7d1d5cdc4101583c251d8d85d20dc2a59b | |
parent | 015dd15c0e75e83f2b4e2f39eb943c3953090c67 [diff] |
[125] Remove a NOTREACHED that can happen People on iPad can have manually enabled tab-groups-in-grid but not modern-tab-strip. This CL adds a DumpWithoutCrashing instead of a NOTREACHED, to still get the signal about those iPads, but not have them crash. (cherry picked from commit 486211f7a9740690c12edbe293f7eb68d77b17ca) Bug: 333377248 Change-Id: I1a2680105fb49019828a1b022696ede00b2a1677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514751 Auto-Submit: Louis Romero <lpromero@google.com> Reviewed-by: Ewann Pellé <ewannpv@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Éric Noyau <noyau@chromium.org> Commit-Queue: Louis Romero <lpromero@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1296780} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5518412 Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/6422@{#767} Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.