Google Git
Sign in
chromium / chromium / src / dc778ef2640dfd02ee7a896b92cd72e8f6d5cdf1
commitdc778ef2640dfd02ee7a896b92cd72e8f6d5cdf1[log] [tgz]
authorAbhishek Pandit-Subedi <abhishekpandit@google.com>Tue Mar 07 18:55:33 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 07 18:55:33 2023
tree56961544a5af00aa90f9e8699eed47436c3cb2c7
parentd45c23691aacbb561a48e32a9a91e8a260491e05 [diff]
arc: Handle missing characteristic and permissions

Updates WriteGattCharacteristic to check if the characteristic exists
before writing to it. Currently, this is only protected via a DCHECK.

Also removes all permission checks when reading and writing remote
characteristics and descriptors. According to the Bluetooth Core Spec,
Vol 3, Part F, 3.2.5, the permission values cannot be discovered via ATT
so most implementations will just return 0.

BUG=b:270385079
TEST=out/Default/unit_tests --gtest_filter="ArcBluetoothBridgeTest.*"

Change-Id: Ie4a8068d6e29f19ab9a58b55b6babf000a0b7773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4311090
Reviewed-by: Gordon Seto <gordonseto@google.com>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Commit-Queue: Abhishek Pandit-Subedi <abhishekpandit@google.com>
Cr-Commit-Position: refs/heads/main@{#1114080}
2 files changed
tree: 56961544a5af00aa90f9e8699eed47436c3cb2c7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.