commit dcaa344301962e932d2520016bc1cd714aab59d9
author Timofey Chudakov <tchudakov@google.com> Tue Feb 27 10:46:14 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 27 10:46:14 2024
tree 3cc7cc7d9b10d66b2f8dfbdddfa4d2514a71b52c
parent 0515d95af1fa94383bf204144009404281493c80

[Mullhet] Fix password form preview.

Previously landed CLs crrev.com/c/5307518 and crrev.com/c/5307397
changed the password form preview UX behavior. The root cause of the
change is that:
* PAA::FillPasswordSuggestion is called when the user accepts the
suggestion. This overwrites the previewed suggested value.
* PAA::ClearPreviewedForm is called when the Autofill popup is closed.
This call is done after the call to PAA::FillPasswordSuggestion. This
function is a no-op if the fields' suggested values are empty.

Before crrev.com/c/5307518, the password form preview was never cleared
because of the behavior described above. After the CL, the preview
was cleared after the fields are filled. That's why the lost blue
background highlighting.

The solution is to clear preview in PAA::FillPasswordSuggestion as it
is done in the AutofillAgent. This CL also removes
PreviewInfo::prefix_length because it's not needed to implement the
observed behavior.

PAA = PasswordAutofillAgent

Before any changes:
http://screencast/cast/NTI1MTg3NDI4NTQyMDU0NHxhNTdiZWRjMi00Mg

After crrev.com/c/5307518 and crrev.com/c/5307397:
http://screencast/cast/NDUwNzcwNTM2NzU5Mjk2MHxjYTE3MmI3Zi1kNw

After fix in this CL:
http://screencast/cast/NjA5MzczMzcxMDc5MDY1NnxmZDVlMGNjMy02OA

Bug: b/326879023
Change-Id: I69c3d3e1435e239637b99c072bdbdb56d57b19c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323082
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Timofey Chudakov <tchudakov@google.com>
Cr-Commit-Position: refs/heads/main@{#1265709}