commit | 2b105e4e5d7dafed6bb70861b7eac793d25e0224 | [log] [tgz] |
---|---|---|
author | Nate Fischer <ntfschr@chromium.org> | Wed Jan 23 21:59:11 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 23 21:59:11 2019 |
tree | 78d148863b6fb071ba2defc304b5936e4fceb738 | |
parent | 81e6f26a234074b9fb26044f8a4d21f4b08cbbd0 [diff] |
AW: run_cts auto-determines device arch This adds proper logic to run_cts.py to auto-determine the device architecture, and to throw an error if the device architecture is not supported. This also adds unit tests (and configures them to run on presubmit). Although this is not a significant improvement (we still only support "arm64"), this gives fast, clear feedback when the device is unsupported (e.g., emulators), and the logic should generalize as we support more architectures. This also adds logging (which will be visible with --verbose, to aid debugging). This does minor refactoring in the script, to plumb arch where it's used instead of reassigning to args.arch (which should help with testability in the future). R=aluo@chromium.org Bug: 922854 Test: vpython android_webview/tools/run_cts_test.py Test: android_webview/tools/run_cts.py (script still runs) Change-Id: I6528ab836f30b5885ede59853acaeee69de26fa2 Reviewed-on: https://chromium-review.googlesource.com/c/1419840 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625376}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .