[Test Automation] ExecuteJs[At], CheckJs[At] fail on error Previously, ExecuteJs, ExecuteJsAt, CheckJs, and CheckJsAt could swallow relevant error information if an exception was thrown, or (in the case of the ...At() versions) if the element was not present. This rewrites the JS injection logic for these methods so that all errors are caught and explicitly surfaced as test failures, with their JS error messages. This includes any of: - DeepQuery path not found - Exception thrown by injected function - Injected function returns a promise which then calls 'reject' In order to handle the case where executed JS may destroy or navigate the current web page, an optional "fire and forget" mode is added to ExecuteJs[At] which preserves the old behavior (though you will not get error checking in that case). Numerous tests ensuring functionality are also added. Bug: 1478691 Change-Id: Ibbd0d713e4dad7783958107943e2abc934bc30ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846076 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/main@{#1195627}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.