Ensure that pages with non-sticky reasons can enter BFCache twice.

BUG: When a page with a non-sticky reason navigates, it may clear that
reason in `pagehide`. If that page is restored and gets a non-sticky
reason again, clearing the reason in pagehide did not work the second
time.

CAUSE: When a page is navigating, we do a pre-pagehide check to see if
there are blocking reasons. This ignores non-sticky reasons. If there
ar e none, the page enters BFCache and we do a post-entry check to
make sure that there are no blocking reasons of any
kind. `PageLifecycleStateManager::did_receive_back_forward_cache_ack_`
tracks whether the page has fully entered BFCache and is used to
decide which kind of check we perform. This bit was not reset on
leaving BFCache so the pre-pagehide check was using the post-entry
criteria, second time around.

FIX: Reset `did_receive_back_forward_cache_ack_` on leaving BFCache.

This puts the fix behind a flag (default on) so that we can measure
the impact.

Bug: 360183659
Change-Id: Ie7d94e5d64b2b7a483a5d4c9bfb6d56582fe6615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087162
Auto-Submit: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395838}
4 files changed
tree: 7b19fcab168743f971bd216971354ef49e8b2ca9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.