| commit | dd29e80fb38a5d45b784d581133c98bf4abce250 | [log] [tgz] |
|---|---|---|
| author | Mikel Astiz <mastiz@chromium.org> | Mon Mar 01 16:30:12 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 01 16:30:12 2021 |
| tree | b904aa7afcae77f91f797678ca90bd47dd4a8521 | |
| parent | 847e81b32f0d7bb0d2d87970793be4f4bd5c2996 [diff] |
[sync] Delete some unused proto fields in CommitResponse These fields are literally dead code on the client since M86, when the pre-USS codebase was deleted, but older versions of the browser (manually verified with M56) considered them optional and barely used them anyway, because it was only used within GetResultingPostCommitName() where it fell back to the name of the entity being committed (i.e. in case the server overwrote the name during commit, which doesn't happen in practice). Note also that the server doesn't populate these fields, except for |name| which is indeed populated for legacy reasons. Change-Id: I764c0e294d46a8a090b850a6114b4894a8708aba Bug: 1182252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720142 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#858571}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.