Google GitGoogle Git
Sign in
chromium/chromium/src/dd50fb2e76b262a2d3308b64252fc7d3a86c7b17
commit
dd50fb2e76b262a2d3308b64252fc7d3a86c7b17
[log]
author
Luciano Pacheco <lucmult@chromium.org>
Tue Mar 17 00:10:02 2020
committer
Commit Bot <commit-bot@chromium.org>
Tue Mar 17 00:10:02 2020
tree
0f75f275f36d7ef2b6e6c66003214e3be5926323
parent
87cb788b84c9c4546f239ecda2f3dbdaed256f92 [diff]
Files app: Fix rename from select all

Change selectAll() to force a leadIndex if there is none, because having
something selected without a leadIndex doesn't make sense. leadIndex is
the currently focused item.

This fixes renaming from context menu or selection menu when user has
selected files only via "select all", without selecting any file file
before the "select all" command.

Bug: 1051899
Fixed: 1051899
Change-Id: I2a2f565af1341abd89f8bc9900e8a5b10595ee0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104737
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750787}
3 files changed
tree: 0f75f275f36d7ef2b6e6c66003214e3be5926323
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.