Google Git
Sign in
chromium / chromium / src / dd9ac0a02c12d5008b80b220fe00c4359577ce34
commitdd9ac0a02c12d5008b80b220fe00c4359577ce34[log] [tgz]
authorXiaoqian Dai <xdai@chromium.org>Thu Feb 18 18:45:43 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 18 18:45:43 2021
tree5f5eddb371482b63ff24236e7fa5378eedeef807
parent15dd6bf89e153ba1c9a53c7b27188be797088246 [diff]
split view: WM snap event should put window in split view.

Currently a window in split screen will have kLeftSnapped or
kRightSnapped state, but a window with kLeftSnapped or kRightSnapped
state may not be in split screen - which is a scenario that should not
happen in tablet mode. Also sending a snap WMEvent
(WM_EVENT_SNAP_LEFT/RIGHT) directly to a window does not trigger split
screen - which also should not happen in tablet mode.

This CL does the following change:
- In tablet mode: A window with kLeftSnapped or kRightSnapped state
is guaranteed to be in split view. Sending a snap WMEvent to the window
can put the window in split view automatically.
- In clamshell mode: sending a snap WMEvent to a window will only put
the window in intermediate split view if overview is open at the moment.
- Introduce the concept of to-be-snapped windows in split view. Only
after the window's state is changed successfully to snapped window
state, split view state will change accordingly. This can ensure only
necessary change will be made to split view.

Bug: 990494, 990713, 1107189
Change-Id: I14c904fc9cdd8ae57e26c53ff3bf5e4a6cc629e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618581
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#855360}
12 files changed
tree: 5f5eddb371482b63ff24236e7fa5378eedeef807
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.