Google Git
Sign in
chromium / chromium / src / dda15c4ee2761a84ca696c532593ae3a8b9c88b4
commitdda15c4ee2761a84ca696c532593ae3a8b9c88b4[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Fri Oct 20 17:07:56 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 20 17:07:56 2023
tree622a061fb80d8b1693f7d0abf6699e3a8a8e7e66
parent64583b4f002300ab6b1c5e973844f137be4e8c8d [diff]
[bookmarks] Rename BookmarkSyncServiceFactory to be more precise

Following the name under ios/, the factory responsible for
instantiating the regular, local-or-syncable instance of
BookmarkSyncService, should be named
LocalOrSyncableBookmarkSyncServiceFactory.

In future patches, a second factory will be introduced, representing
another BookmarkSyncService instance that exclusively deals with account
bookmarks.

Patch generated using:
git mv chrome/browser/sync/bookmark_sync_service_factory.cc \
  chrome/browser/sync/local_or_syncable_bookmark_sync_service_factory.cc
git mv chrome/browser/sync/bookmark_sync_service_factory.h \
  chrome/browser/sync/local_or_syncable_bookmark_sync_service_factory.h
./tools/git/mass-rename.py
git grep -l 'BookmarkSyncServiceFactory' -- chrome | \
  xargs sed -i 's/BookmarkSyncServiceFactory/LocalOrSyncableBookmarkSyncServiceFactory/g'
git cl format

Manually sort chrome/browser/profiles/profile_keyed_service_browsertest.cc.

Bug: 1494120
Change-Id: I2afe4a031808fdd4773af9e8e9a73f95994a8ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4957235
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1212826}
10 files changed
tree: 622a061fb80d8b1693f7d0abf6699e3a8a8e7e66
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.