Google Git
Sign in
chromium / chromium / src / 21725720cf7084fd17e990ecefff80805ca0f3af
commit21725720cf7084fd17e990ecefff80805ca0f3af[log] [tgz]
authorJosh Nohle <nohle@google.com>Tue May 18 20:50:14 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 18 20:50:14 2021
tree641a70b02e5c93c727f80d417be2a9e8a2ef2957
parent21e17e1daf7fd99dadd47aff26251817f5f39018 [diff]
[Nearby] Log metrics on enabled/disabled state change

Previously, Nearby.Share.Enabled was only emitted on sign-in. This
makes data analysis tricky because Nearby.Share.Enabled is not
immediately updated after onboarding, for example. The metric becomes
a lagging indicator.

In this CL, we emit to Nearby.Share.Enabled on sign-in and also when
the feature state changes. We also log a new metric,
Nearby.Share.EnabledStateChanged, that only tracks changes from
disable to enabled and vice versa.

Manually verified histograms via chrome://histograms

Bug: 1105579
Change-Id: I3c2ea03ce7e6c734e99bb944783d6a08f6317606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2904121
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#884132}
3 files changed
tree: 641a70b02e5c93c727f80d417be2a9e8a2ef2957
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.