Google Git
Sign in
chromium / chromium / src / ddc6b7a5c9165de6b9e06d8a23c4e38e997e747d
commitddc6b7a5c9165de6b9e06d8a23c4e38e997e747d[log] [tgz]
authorBenoit Lize <lizeb@chromium.org>Fri Dec 10 09:19:43 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 10 09:19:43 2021
treef021bd682e7515cb85886b3bdb54f5b59564e2b3
parent0c70c68482bdbdc7e9f39c023742f1609de0762a [diff]
[base/allocator] Don't export operator new/delete on macOS.

On macOS, the default operators for new and delete are exported by
default. This is unneeded and undesirable, and can be removed by setting
a compiler flag, which we were already setting when compiling libc++.

This also allows us to remove the NO_CODE_FOLDING() hack, which was
required with Identical Code Folding.

This can be checked with:
$ nm -gU out/Default/Chromium.app/Contents/Frameworks/Chromium\ Framework.framework/Versions/Current/Chromium\ Framework | c++filt

which shows that the symbols are no longer exported.

Bug: 1121427
Change-Id: Ifcf65c227490208497cd07d549241b00645796fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327026
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#950474}
3 files changed
tree: f021bd682e7515cb85886b3bdb54f5b59564e2b3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.