| commit | dde975ad6d38e0ea8432cdd627b60f6ba0bfbc3b | [log] [tgz] |
|---|---|---|
| author | Pavel Yatsuk <pavely@google.com> | Tue Jun 01 21:16:36 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 01 21:16:36 2021 |
| tree | ec5413e76a2ad9d40f1139d6c903a91bc1101992 | |
| parent | 36e60ea042992265c93337746269f1b3c84c4eae [diff] |
Ensure ChromeMessageQueueMediator#setLayoutStateProvider is not called after destroy() The crash stack suggests that mQueueController was null at the time when LayoutStateObserver#onStartedShowing was called. mQueueController is set in ctor and only reset to null in #destroy(), where mLayoutStateObserver is removed from observer list. This suggests that setLayoutStateProvider was called after the call to destroy(). This CL adds a check that throws an exception if setLayoutStateProvider is called after destroy() to help identify scenarios when it happens. BUG=1199059 R=lazzzis@chromium.org Change-Id: I2a8315ef8981541e94678667e0ac3731c75ff835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2925749 Reviewed-by: Lijin Shen <lazzzis@google.com> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#888131}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.