Revert "[Bookmarks] Fix opaque background behind bookmark dialogs on tablets" This reverts commit 6483ed9ce2775befc8913c1fa73916333ffe77f0. Reason for revert: BookmarkFolderPickerActivityTest deterministically failing on android-10-x86-rel Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/10293/overview Original change's description: > [Bookmarks] Fix opaque background behind bookmark dialogs on tablets > > On large-screen Android devices such as foldables and tablets, the > bookmark edit and folder picker activities are presented as floating > dialogs. A recent change to the edge-to-edge layout caused these > dialogs to expand their decor bounds and paint over the dimmed > browser UI, leaving a completely black backdrop. > > The issue stems from the edge-to-edge layout being disabled only > when the desktop bookmark dialog flag was enabled. On tablets, the > activities would draw edge-to-edge, expanding the floating dialog > bounds. Furthermore, the DialogWhenLarge theme lacked the translucent > window attribute on large screens, causing WindowManager to treat the > activity as occluding its parent. This stopped the parent tabbed > activity and hid its compositor surface. > > To fix this, the translucent window attribute is added to the > DialogWhenLarge theme for large screens. Additionally, the bookmark > activities now override the edge-to-edge creation and layout wrapping > methods to opt out whenever they are presented as a dialog. This > ensures the underlying browser UI remains visible and appropriately > dimmed. > > Bug: 568847039 > Change-Id: I1008172fba9afda1e808d97a3ff1c3187625df75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8518060 > Reviewed-by: Brandon Fong <bjfong@google.com> > Auto-Submit: Brandon Wylie <wylieb@google.com> > Commit-Queue: Brandon Fong <bjfong@google.com> > Cr-Commit-Position: refs/heads/main@{#1712532} Bug: 568847039 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7a4717431caeef5c8f696e94c1327ca7cf2b3369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8522934 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#1712782}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.