Revert "[Bookmarks] Fix opaque background behind bookmark dialogs on tablets"

This reverts commit 6483ed9ce2775befc8913c1fa73916333ffe77f0.

Reason for revert: BookmarkFolderPickerActivityTest deterministically failing on android-10-x86-rel

Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/android-10-x86-rel/10293/overview

Original change's description:
> [Bookmarks] Fix opaque background behind bookmark dialogs on tablets
>
> On large-screen Android devices such as foldables and tablets, the
> bookmark edit and folder picker activities are presented as floating
> dialogs. A recent change to the edge-to-edge layout caused these
> dialogs to expand their decor bounds and paint over the dimmed
> browser UI, leaving a completely black backdrop.
>
> The issue stems from the edge-to-edge layout being disabled only
> when the desktop bookmark dialog flag was enabled. On tablets, the
> activities would draw edge-to-edge, expanding the floating dialog
> bounds. Furthermore, the DialogWhenLarge theme lacked the translucent
> window attribute on large screens, causing WindowManager to treat the
> activity as occluding its parent. This stopped the parent tabbed
> activity and hid its compositor surface.
>
> To fix this, the translucent window attribute is added to the
> DialogWhenLarge theme for large screens. Additionally, the bookmark
> activities now override the edge-to-edge creation and layout wrapping
> methods to opt out whenever they are presented as a dialog. This
> ensures the underlying browser UI remains visible and appropriately
> dimmed.
>
> Bug: 568847039
> Change-Id: I1008172fba9afda1e808d97a3ff1c3187625df75
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8518060
> Reviewed-by: Brandon Fong <bjfong@google.com>
> Auto-Submit: Brandon Wylie <wylieb@google.com>
> Commit-Queue: Brandon Fong <bjfong@google.com>
> Cr-Commit-Position: refs/heads/main@{#1712532}

Bug: 568847039
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7a4717431caeef5c8f696e94c1327ca7cf2b3369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8522934
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1712782}
6 files changed
tree: 2fd5c293d36540c220705551dfdf28f730cff5a2
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .yapfignore
  66. ATL_OWNERS
  67. AUTHORS
  68. BRANCH_FEATURE_OWNERS
  69. BRANCH_OWNERS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. package.json
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. vpython.toml
  87. vpython.toml.uv.lock
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.