Google Git
Sign in
chromium / chromium / src / ddfb06ad5c6ffee3eefba5b567eea3f4f6d00014
commitddfb06ad5c6ffee3eefba5b567eea3f4f6d00014[log] [tgz]
authorYao Xiao <yaoxia@chromium.org>Wed May 22 19:19:02 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 22 19:19:02 2024
treea7b4d35618afb1ff2784ef9c7c6359126978eb4b
parent65df7071cbf4e677e82b6b454a2a500313561394 [diff]
[shared storage] Fix some web platform tests

Issue: Some WPTs finish too early and does not actually wait for the
async operations. We encountered test failures due to a mojom
connection CHECK on `CodeCacheHost`, which reveals this underlying
problem.

This patch fixes those cases. Also, for
shared-storage-writable-img-idl-attribute-included-bytes.tentative.https.sub.html,
there are some additional problems:
- The "+" is a special URL character. Thus, we apply
  encodeURIComponent on the key/value.
- Passing emoji character directly doesn't seem to work. It's
  being translated to a different/unexpected sequence. In this CL,
  we replace the emoji with explicit UTF-16 code units created from
  String.fromCharCode(). Filed a bug (https://crbug.com/341973427)
  for further investigation.



Bug: 341893986
Change-Id: I208e4af410a3a1092a0da88decbe43687fe8b718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5556543
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304604}
5 files changed
tree: a7b4d35618afb1ff2784ef9c7c6359126978eb4b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.