Google Git
Sign in
chromium / chromium / src / ddfc89b7c2f41f56d1f4ad2d22ee3e8a82cac75d
commitddfc89b7c2f41f56d1f4ad2d22ee3e8a82cac75d[log] [tgz]
authorwenyu zhang <zhangwenyu@google.com>Tue Nov 08 18:51:43 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 08 18:51:43 2022
tree328a8f56a54f4e12764212c6a9ef4c498d7daf1a
parente30d5432b5403dad2112b8ad3a1ffba3bf5017d9 [diff]
diagnostics: Simplify MoveAppToTestingScreen API to not return anything

The current boolean returned is not being used in frontend. The return
result doesn't seem be to valuable for any metrics. Simplify both
MoveAppToTestingScreen and MoveAppBackToPreviousScreen function. Remove
await in frontend since it doesn't affect the behavior.

This CL addresses the comment in previous CL.
https://chromium-review.googlesource.com/c/chromium/src/+/3979068/
comment/7d2b7fe3_b4ceb777/

gtest_filter=DiagnosticsAppWithInput_InputList.All,

Bug: b/253234353
Test: JS browser test --
Test: input_data_provider_unittest
Change-Id: I6b0ec68219210aa18b3ed0526ad005b6e3cfc176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4003539
Reviewed-by: Chris Bookholt <bookholt@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Wenyu Zhang <zhangwenyu@google.com>
Reviewed-by: Ashley Prasad <ashleydp@google.com>
Cr-Commit-Position: refs/heads/main@{#1068675}
6 files changed
tree: 328a8f56a54f4e12764212c6a9ef4c498d7daf1a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.