commit | de1b0f86f89ee48ff15f1f7237afbd0b48cf52dd | [log] [tgz] |
---|---|---|
author | Filipa Senra <fsenra@google.com> | Tue Dec 27 15:07:39 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 27 15:07:39 2022 |
tree | ea2dfcc4162976df30d98470e512a21b5c2b572e | |
parent | 5799d95718d82ac46f774647c2c84683b4b40999 [diff] |
[Android][Privacy Guide] Refractor PrivacyGuidePagerAdapter constructor The existing way of creating the list of fragment types on PrivacyGuidePagerAdapter is error prone as it relies on the author to remember the ordering of the FragmentType and then manually go over them in that order and add them in the |mFragmentTypeList|. A change in this order would rely on the author to also remember to change this which is not very apparent. In this CL, we move away from this approach by iterating over FragmentType and add each type to |mFragmentTypeList| in the order they are declared in FragmentType. Change-Id: Ic5d3d7c779fc9d50e05bdf727a62f779d8bbd570 Fixed: 1395776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4110883 Reviewed-by: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by: Rubin Deliallisi <rubindl@chromium.org> Commit-Queue: Filipa Senra <fsenra@google.com> Reviewed-by: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1087105}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.