commit | de285c3d66ca8016d06afee5c5200a6551659375 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Thu Nov 08 17:22:54 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 08 17:22:54 2018 |
tree | 394eea1f6e722c6f41fbe9cd645561df263ff24a | |
parent | c20c1c500247065143478cf1dfb0d04ef5a8558f [diff] |
Avoid shadowing UNKNOWN (defined in both quic and ftp) If you include both net/ftp/ftp_directory_listing_parser.h and net/quic/quic_chromium_client_session.h you get an error about an UNKNOWN shadowing another UNKNOWN. I don't think this is a new problem but something we got with a new clang version. This renames the net::UNKNOWN to net::UNKNOWN_CAUSE so that net::FtpDirectoryListingEntry::UNKNOWN and other unknown UNKNOWNs can stay. net/ftp/ftp_directory_listing_parser.h:21:5: error: declaration shadows a variable in namespace 'net' [-Werror,-Wshadow] UNKNOWN, ^ net/quic/quic_chromium_client_session.h:83:3: note: previous declaration is here UNKNOWN, ^ 1 error generated. TBR=zhongyi@chromium.org Change-Id: I96c6c8ba3b923a691537debbfe468874c767b939 Reviewed-on: https://chromium-review.googlesource.com/c/1326494 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#606509}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .