Google Git
Sign in
chromium / chromium / src / de67bfe0dab99f2160a8c3b2db01dec19ce80c3e
commitde67bfe0dab99f2160a8c3b2db01dec19ce80c3e[log] [tgz]
authorMingyu Lei <leimy@chromium.org>Tue Dec 20 12:01:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 20 12:01:36 2022
treec98687a0898caa8736ef2579f3cd09d20445f158
parentfc6d56abf08fcd62c7b7ac736691d467e2d08445 [diff]
[IndexedDB] Check if the connection callback is null in the closure

When the IndexedDB service sends the versionchange event, the connection
is passed as a weak pointer to the closure, and that will only run if
the client is active. We have the null check for the connection pointer
itself, but not for the `callbacks_`.

The `callbacks_` object could be reset to nullptr during
`IndexedDBConnection::AbortTransactionsAndClose()`, if the closure runs
after the event but before the IndexedDBConnection is destroyed, we may
end up trying to invoke the `OnVersionChange()` method on a null
pointer.

Bug: 1402021
Change-Id: Ic1ad4d366d5e37fb537b6c03b6a24d9efb7cb952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113383
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1085379}
1 file changed
tree: c98687a0898caa8736ef2579f3cd09d20445f158
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.