Google Git
Sign in
chromium / chromium / src / dea28be7553384382c46b124dab8edc38bb60c32
commitdea28be7553384382c46b124dab8edc38bb60c32[log] [tgz]
authorMarc Treib <treib@chromium.org>Fri Jul 12 06:15:55 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 12 06:15:55 2024
tree123c7773dcf3c6347e21fbaf2813291cc986fd45
parent8b41b33e535322ee511615381025b5a030d544da [diff]
Sync: Implement GetTypesWithUnsyncedData off the sync sequence

Before this CL, the implementation of GetTypesWithUnsyncedData involved
the sync sequence (ultimately, the data came from ModelTypeWorker). This
was nice and simple, but didn't work well when the sync sequence was
busy, most notably during initial sync.

This CL replaces that implementation with one that avoids the sync
sequence entirely. It instead gets the data directly from the model
thread(s), via ModelTypeController -> ModelTypeControllerDelegate (aka
processor).

There is one change (in addition to not blocking on the sync
sequence): The behavior in case of ModelErrors.
Previously, types that have encountered a ModelError would not report
any unsynced changes. Now they will report them.
This will rarely make a difference (after all, ModelErrors are
hopefully rare!) but seems like an improvement.

Bug: 349970109
Change-Id: I50e4e860242283e7b3498c510e2bbb3d8788dcc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5683369
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1326570}
28 files changed
tree: 123c7773dcf3c6347e21fbaf2813291cc986fd45
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.