commit dea4d8f82990014610413857de846e0d5d6fb62f
author Kevin Grosu <kgrosu@google.com> Wed Sep 28 22:12:48 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 28 22:12:48 2022
tree a8a43bbf0748b4f26c84a35444edec2a9489200f
parent 7f66748269ae3cc6a1e37f4a00e838dd643636d8

[CCT] Toolbar disappears when scroll up, after switching theme

This is happening because when switching themes the BrowserControlsState is incorrectly reported as BrowserControlsState.BOTH instead of BrowserControlsState.SHOWN when EXTRA_ENABLE_URLBAR_HIDING is not set or set to false. Upon investigation it seems that on the normal boot/loading of the CCT the TabStateBrowserControlsVisibilityDelegate updateVisibilityConstraints method is being called as part of different tab events that are being observed. However, in the theme change logic, these values are no longer called (mostly because the page is already loaded) for the object the is being used to determine the BrowserControlsState for the current CCT.

Looking at the TabStateBrowserControlsVisibilityDelegate constructor it is not calling updateVisibilityConstraints() while all the other visibility delegates (BrowserStateBrowserControlsVisibilityDelegate, CustomTabBrowserControlsVisibilityDelegate,ComposedBrowserControlsVisibilityDelegate) are calling it (or similar logic). Adding the call to updateVisibilityConstraints() fixes the issue observed and now the BrowserControlsState is correctly calculated when EXTRA_ENABLE_URLBAR_HIDING is not set or set to false.

Please see the linked bug for more information about the investigation of the issue.

Bug: 1360447
Change-Id: Id8f8e9b5dfef59cbd683bbecc4608e8f31e8805d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923976
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Kevin Grosu <kgrosu@google.com>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1052667}