commit | dea73c9ea7cc2113e59e95c14d1d980889055a26 | [log] [tgz] |
---|---|---|
author | Michelle <michellegc@google.com> | Thu Sep 28 08:05:30 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 28 08:05:30 2023 |
tree | dddf4523c2362621ba981560c2da73195c323bf5 | |
parent | 5f91fd1996ccb23b25367913929072a1912fe687 [diff] |
Adjust chips layout based on editor menu width. When setting or updating EditorMenuView's width, update the layout of the chips container so that the chips fit nicely into rows. Doesn't seem like there is a standard way to do this, so we just recreate the layout by removing existing rows and creating new rows, and std::moving the chip views. The editor menu's width only updates when its anchor bounds update (usually when the context menu initially appears, then maybe again if a context menu item's icon later loads), so it is probably ok to update the layout like this every time the anchor bounds update. Padding around the chips container isn't exactly to specs yet. Will polish in follow ups. Bug: b:302241013 Change-Id: I33105c4cec4145fa872c4acb75a7c99597f27a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4899378 Commit-Queue: Michelle Chen <michellegc@google.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1202414}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.