commit | dedc3bdd4527e11b054887fd623a2b3bc7591aa7 | [log] [tgz] |
---|---|---|
author | Guillaume Jenkins <gujen@google.com> | Wed Feb 24 17:53:29 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 24 17:53:29 2021 |
tree | f50daf455fceed08d429f126b0515525422054e2 | |
parent | 16bdd5619e7935a4e6d9678e7ced586b5eb37028 [diff] |
[iOS Enterprise] BrowserSignin: Return early in sign-in coordinator Adds a check before the SigninController is started to ensure sign-in is available. If it isn't, the sign-in completion is immediately invoked with success = false. This is needed in order to handle a cloud policy edge case where browser sign-in can become disabled while the user is already looking at a sign-in entry point, because most sign-in entry points don't reflect the new policy value until their view controller is recreated. Bug: 1155745 Change-Id: I9cf97307f9e82181e49b2cb3078e334a7df1dd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698470 Reviewed-by: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#857241}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.