Add ReadAndDiscard option to URLLoader

Add a new URLLoader option which requests that it read and discard the
response body itself rather than writing it to a data pipe. This is more
efficient when the consumer doesn't need the body. The URLLoaderClient
will be passed an empty data pipe handle in OnReceiveResponse().

The new option is only implemented for network::URLLoader. Because there
are over 500 implementations of URLLoaderFactory::CreateLoaderAndStart()
it is not possible to implement the option in all of them. Instead,
implementations of URLLoaderClient must be prepared to receive and
discard a body even if they requested the option.

The option is currently disabled when ORB is enabled as we don't need it
in that case and it complicates the implementation.

Add a feature flag "SimpleURLLoaderUseReadAndDiscardBodyOption" which
causes SimpleURLLoader to set the kURLLoadOptionReadAndDiscardBody
option when creating a URLLoader in the DownloadHeadersOnly() method. If
the URLLoader supplies no body in this case the body is considered to be
successfully downloaded.

Modify SimpleURLLoader's unit tests to test all three cases of flag
enabled, flag disabled, and flag enabled but the option not implemented
by the URLLoader.

Also add a fieldtrial testing config for the feature flag so that it
will be enabled in browser tests to give additional coverage.

Change-Id: I1d609f679334f8650dac27a51bfc90ec972c784c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348681
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271270}
8 files changed
tree: d5076b2cb53ced5c89341be7f8bc2ea4b5ac25d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.