commit | df26424cb35c04a01b141c874b4195d53cd6fa5f | [log] [tgz] |
---|---|---|
author | Alexander Hendrich <hendrich@chromium.org> | Mon Mar 17 10:38:04 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 17 10:38:04 2025 |
tree | 4394da9834257a5b1260ac10e06b094e57723817 | |
parent | 1c50cb3324eaccb1cd30de71086a00e393293762 [diff] |
Respect default_for_enterprise_users in simple pref mapping tests When a CrOS policy uses default_for_enterprise_users, the pref mapping tests were not able to use the simplified format since the test case for the default scenario (no policy set) was using `default_value`, which actually checks that the pref is unmanaged. However, `default_for_enterprise_users` causes the policy to be set with the default value if no other policy value is set and therefore the pref would also be managed. With this CL, we also allow to use `default_for_enterprise_users` in the simplified pref mapping test format, which checks said value against a managed pref (by using `value` instead of `default_value`). We also have to account for cross-platform policies, where the `default_for_enterprise_users` only affects CrOS and the `default_value` should still be used for non-CrOS. I've updated all policy test cases for policies starting with letters A-H accordingly. Remaining policies will be updated as part of crbug.com/327182578. Fixed: b:403195440 Bug: b:403195440, b:327182578 Change-Id: I9c8aae93e4d6029d28fe743c84f0c385a6b04df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6356953 Reviewed-by: Leon Masopust <lmasopust@google.com> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Aya Elgendy‎ <ayag@chromium.org> Cr-Commit-Position: refs/heads/main@{#1433425}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.