commit | df2f94e39fc1a200f8baf2f3bb55fd717f487719 | [log] [tgz] |
---|---|---|
author | Omar Elmekkawy <mekk@google.com> | Wed Feb 16 10:31:10 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 16 10:31:10 2022 |
tree | 846db9d9f59fa34048b566a6aabd46d78697a720 | |
parent | 569f6ef3743a388f99d81f987b56bae2b9f814a8 [diff] |
Using HardwareRenderer to draw omnibar instead of Canvas API This CL is an attempt to fix crashes caused by migrating the renderer to hardware accelerated drawing, replacing the Canvas API calls with the HardwareRenderer call, the gains in drawing time observed after the migration are still observed with the new API. This is controlled by --enable-features=ToolbarUseHardwareBitmapDraw and only works on Android 10 or higher. This was tested via generating traces with software/hardware drawing, using the same query used for the previous CL. https://crrev.com/c/2611455/37 SELECT AVG(dur), min(dur), max(dur), count(*) FROM slice WHERE name LIKE "%captureWithHard%" AND ( SELECT descendant.id FROM DESCENDANT_SLICE(slice.id) AS descendant LIMIT 1 ) IS NOT NULL; HardwareDraw AVG(dur) min(dur) max(dur) count(*) 2968600 990000 5943000 5 3757500 1626000 5303000 4 2755400 890000 5658000 5 SELECT AVG(dur), min(dur), max(dur), count(*) FROM slice WHERE name LIKE "%captureWithSoft%" AND ( SELECT descendant.id FROM DESCENDANT_SLICE(slice.id) AS descendant LIMIT 1 ) IS NOT NULL; SoftwareDraw AVG(dur) min(dur) max(dur) count(*) 9798200 3079000 14491000 5 9942500 3976000 17231000 6 9981800 3458000 14530000 5 Bug: b/193501524,1185197 Change-Id: I7a2d8f1388e368c3ffa1857854744802de7b193c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452087 Reviewed-by: Stephen Nusko <nuskos@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Omar Elmekkawy <mekk@google.com> Cr-Commit-Position: refs/heads/main@{#971726}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.