commit | df33ea61b503f9ff33e3dbde465fe1f0e8534eea | [log] [tgz] |
---|---|---|
author | Tommy C. Li <tommycli@chromium.org> | Wed Mar 29 23:04:52 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 29 23:04:52 2023 |
tree | a1ca6dfd1bfc6ebad6ebd74fc6b01c473408f835 | |
parent | bfaf7e73f0394858ee432f2031079545e298fc31 [diff] |
[page_image_service] Rename directory to `page_image_service`. We started with `image_service` but multiple reviewers have complained that this is too generic of a name. We settled on `page_image_service` to clarify that this provides an image relevant to a specific page. We rejected a bunch of other names so please let's not relitigate it. This CL is a pure directory and namespace rename. I didn't even rename the C++ classes yet, because my goal was to keep this as mechanical and easily reviewable as possible. Bug: b/244507194, 1367485, b/248367751 Change-Id: I52126f24c12757225a01c0ad0cee24b2f6435226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4376804 Owners-Override: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/main@{#1123921}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.