Google Git
Sign in
chromium / chromium / src / df3c6d89b2216b9f905e7601c4b9d956efdbf22d
commitdf3c6d89b2216b9f905e7601c4b9d956efdbf22d[log] [tgz]
authorMark Rowe <markrowe@chromium.org>Mon Oct 07 20:07:28 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 07 20:07:28 2024
treeef463fadbdee4bbdcddaa9e0662f1a794c541b85
parent8e9a94af83a1df0d48700805629e028be0d804b9 [diff]
DumpWithoutCrashing if GatherMetrics sees unexpected data

`ProcessRequirement::GatherMetrics` validates that retrieving the team
ID and certificate type for the current process match what we expect to
see in official builds of Chrome. In around 0.5% of cases we are seeing
unexpected values. This introduces crash keys containing the team ID and
certificate type and calls `DumpWithoutCrashing` when we see unexpected
values. This should help in understanding why we're not seeing the
correct value in all cases.

In order to make the data slightly easier to understand, the special
handling of `ENOENT` from `csops(CS_OPS_TEAMID)` is moved out of
`TeamIdentifierOfCurrentProcess` and into `HasSameTeamIdentifier`. This
will make it possible for `GatherMetrics` to distinguish between the
system call successfully returning an empty string and the `ENOENT` case
that represents an unsigned or ad-hoc signed process.

Bug: 362302761
Change-Id: I7321e22666a51d07c5709e0f26d7f4c2a04e0b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912116
Auto-Submit: Mark Rowe <markrowe@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1365106}
1 file changed
tree: ef463fadbdee4bbdcddaa9e0662f1a794c541b85
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.